Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backend: Re-write "Convey" tests to use testify #156

Closed
Tracked by #192
fridgepoet opened this issue Apr 27, 2023 · 0 comments · Fixed by #266
Closed
Tracked by #192

Backend: Re-write "Convey" tests to use testify #156

fridgepoet opened this issue Apr 27, 2023 · 0 comments · Fixed by #266

Comments

@fridgepoet
Copy link
Member

fridgepoet commented Apr 27, 2023

Over time, Grafana's backend testing style has moved from using Convey to testify. For example grafana/grafana#26724
Current to the style guide https://github.com/grafana/grafana/blob/main/contribute/backend/style-guide.md#testing

This remains to be done in this OpenSearch datasource.

It may be helpful to reference the Elasticsearch datasource in the main Grafana repo from which this repo originated. Its tests are already written using testify. https://github.com/grafana/grafana/tree/main/pkg/tsdb/elasticsearch

Note: Marking this as a "good first issue" for anyone who would like to contribute any part of this -- the overall work may be significant, but some tests may be straightforward to re-write.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant