Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert usage of http#CanonicalHeaderKey #61

Closed
jpkrohling opened this issue Apr 13, 2023 · 0 comments
Closed

Revert usage of http#CanonicalHeaderKey #61

jpkrohling opened this issue Apr 13, 2023 · 0 comments
Assignees

Comments

@jpkrohling
Copy link
Collaborator

jpkrohling commented Apr 13, 2023

// Extract X-Scope-OrgID
key := http.CanonicalHeaderKey(orgID)

https://pkg.go.dev/net/http#CanonicalHeaderKey

The canonicalization converts the first letter and any letter following a hyphen to upper case; the rest are converted to lowercase.

So that will convert X-Scope-OrgID to X-Scope-Orgid based on my reading @jpkrohling @rlankfo
We see 500s in Dev for every request - can this be changed / rolled-back?

Originally posted by @leveyjam in #60 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant