Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API and documentation actualization #5

Open
kolesnikovae opened this issue Dec 7, 2023 · 0 comments
Open

API and documentation actualization #5

kolesnikovae opened this issue Dec 7, 2023 · 0 comments
Assignees
@kolesnikovae

Comments

@kolesnikovae
Copy link

Since Pyroscope tracing integration has been rearchitected, some of the configuration options and behaviour specifics should be revisited.

In fact, it makes sense to deprecate all the configuration options (for now) and remove all the tags but pyroscope.profile.id:

  • We always set the span_name label
  • Only the root span can have a profile
  • URLs should not be written as span attributes (as this may cause a fairly serious overhead)

Also, profile_id label is not available in the query expressions and such query will always result in empty response
@kolesnikovae kolesnikovae self-assigned this Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kolesnikovae kolesnikovae

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kolesnikovae