Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cache for parquet headers and symbols #2063

Closed
cyriltovena opened this issue May 12, 2023 · 1 comment
Closed

Add cache for parquet headers and symbols #2063

cyriltovena opened this issue May 12, 2023 · 1 comment

Comments

@cyriltovena
Copy link
Contributor

cyriltovena commented May 12, 2023

We should find a way to cache using memcached parquet headers. this way can quickly seek to the page we want.

For some symbols like strings, functions, locations we should also figure a way to cache those since they are below 10MB each.

Caching read from parquet is not simple though since the parquet library solely rely on io.SeekReader.

See https://parquet.apache.org/docs/file-format/ for the metadata to cache.

@cyriltovena
Copy link
Contributor Author

This is how tempo does it https://github.com/grafana/tempo/blob/main/tempodb/encoding/vparquet/readers.go#L107

If your io.ReaderAt implements that method, parquet-go will call it and tell you the footer

@simonswine simonswine transferred this issue from grafana/phlare Jul 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants