Skip to content
This repository has been archived by the owner on Jul 19, 2023. It is now read-only.

Query time splitting #696

Closed
5 tasks
Tracked by #2057
cyriltovena opened this issue May 15, 2023 · 1 comment · Fixed by #713
Closed
5 tasks
Tracked by #2057

Query time splitting #696

cyriltovena opened this issue May 15, 2023 · 1 comment · Fixed by #713
Assignees
@petethepig @kolesnikovae
Labels
area/database kind/enhancement New feature or request kind/performance

Comments

@cyriltovena
Copy link
Collaborator

cyriltovena commented May 15, 2023 •
edited

We should make a configurable per tenant duration (default to 15m) which we'll use to split queries and run in parallel.

In order of importance:

  • Flame graph queries
  • Histogram queries
  • Flamegraph diff
  • Labels and Series queries
  • Profile type queries

Example of Loki splitting by keeping queries aligned and so cacheable https://github.com/grafana/loki/blob/main/pkg/util/time.go#L90-L114
@cyriltovena cyriltovena mentioned this issue Jul 19, 2023
Closed
3 tasks
@petethepig petethepig self-assigned this May 15, 2023
@kolesnikovae kolesnikovae self-assigned this May 19, 2023
@cyriltovena
Copy link
Collaborator Author

FYI Flamegraph diff should basically re-enqueue in the frontend two flamegraph queries that each get splitted too.

@kolesnikovae kolesnikovae mentioned this issue May 24, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@petethepig petethepig

@kolesnikovae kolesnikovae

Labels
area/database kind/enhancement New feature or request kind/performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Split query by interval grafana/phlare
3 participants
@petethepig @cyriltovena @kolesnikovae