Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: supervisord.conf generated wrong executable names for GitHub datasource #907

Closed
1 of 4 tasks
zoltanbedi opened this issue May 13, 2024 · 1 comment · Fixed by #924
Closed
1 of 4 tasks

Bug: supervisord.conf generated wrong executable names for GitHub datasource #907

zoltanbedi opened this issue May 13, 2024 · 1 comment · Fixed by #924
Assignees

Comments

@zoltanbedi
Copy link
Member

Which package(s) does this bug affect?

  • Create Plugin
  • Sign Plugin
  • Plugin E2E
  • Plugin Meta Extractor

Package versions

4.10.3

What happened?

While updating the create-plugin to the latest version in the github datasource I found that the supervisord.conf generated wrong executable names for it.

Wrong
command=bash -c 'while [ ! -f /root/grafana-github-datasource/dist/gpx_git-hub* ]; do sleep 1; done; /run.sh'

Correct
command=bash -c 'while [ ! -f /root/grafana-github-datasource/dist/gpx_github* ]; do sleep 1; done; /run.sh'

What you expected to happen

I expected the right executable to be there.

How to reproduce it (as minimally and precisely as possible)

Update create-plugin in github datasource. See grafana/github-datasource#305

Environment

System:
    OS: macOS 14.4.1
    CPU: (8) arm64 Apple M2
    Memory: 3.77 GB / 24.00 GB
    Shell: 5.9 - /bin/zsh
  Binaries:
    Node: 20.13.1 - ~/.nvm/versions/node/v20.13.1/bin/node
    Yarn: 1.22.19 - ~/.nvm/versions/node/v20.13.1/bin/yarn
    npm: 10.5.2 - ~/.nvm/versions/node/v20.13.1/bin/npm
    pnpm: 8.14.0 - ~/.nvm/versions/node/v20.13.1/bin/pnpm
  Browsers:
    Chrome: 124.0.6367.158
    Safari: 17.4.1

Additional context

No response

@tolzhabayev
Copy link
Collaborator

@oshirohugo please take a look, maybe can be done as part of #910 or after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants