Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow absolute screenshot URLs in plugin.json #106

Closed
6nv opened this issue Mar 16, 2023 · 2 comments
Closed

Allow absolute screenshot URLs in plugin.json #106

6nv opened this issue Mar 16, 2023 · 2 comments

Comments

@6nv
Copy link
Contributor

6nv commented Mar 16, 2023

pass.ReportResult(pass.AnalyzerName, pathRelativeToMetadata, fmt.Sprintf("plugin.json: %s path should be relative to plugin.json: %s", path.kind, path.path), "Don't use absolute paths inside plugin.json")

My explanation can be found in this forum post. In summary, I am getting this error because I am putting absolute links to my screenshots in plugin.json. I believe that this restriction should be lifted for screenshots, because when relative paths are used, the screenshots are packaged in with the plugin and get an asset size limit warning.

@6nv
Copy link
Contributor Author

6nv commented Mar 16, 2023

I found a temporary fix. Disable the metadatapaths analyzer. Related PR: #107

@academo
Copy link
Member

academo commented Apr 17, 2023

Hi @6nv .

So far we require the screenshot to use relative urls as this is the way our Grafana Catalog works. This is not something we can change in the validator only.

@academo academo closed this as completed Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants