We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
In the legacyplatform inspector (Angular), it would be good to fetch the patterns from GCOM rather than relying on hardcoded ones:
legacyplatform
GCOM API: https://grafana.com/api/plugins/angular_patterns
plugin-validator/pkg/analysis/passes/legacyplatform/legacyplatform.go
Lines 49 to 62 in 0b03aac
Grafana core already has support for it:
https://github.com/grafana/grafana/blob/e9a12598db238b3923ca30a490d4abcaf0b00b65/pkg/services/pluginsintegration/angulardetectorsprovider/dynamic.go#L110
This would save us from having to open yet another PR when we have to chang the Angular detection patterns
The text was updated successfully, but these errors were encountered:
oshirohugo
Successfully merging a pull request may close this issue.
In the
legacyplatform
inspector (Angular), it would be good to fetch the patterns from GCOM rather than relying on hardcoded ones:GCOM API: https://grafana.com/api/plugins/angular_patterns
plugin-validator/pkg/analysis/passes/legacyplatform/legacyplatform.go
Lines 49 to 62 in 0b03aac
Grafana core already has support for it:
https://github.com/grafana/grafana/blob/e9a12598db238b3923ca30a490d4abcaf0b00b65/pkg/services/pluginsintegration/angulardetectorsprovider/dynamic.go#L110
This would save us from having to open yet another PR when we have to chang the Angular detection patterns
The text was updated successfully, but these errors were encountered: