Skip to content
This repository has been archived by the owner on Nov 23, 2021. It is now read-only.

Disabled headers get imported #102

Closed
exploide opened this issue May 28, 2021 · 2 comments · May be fixed by #103
Closed

Disabled headers get imported #102

exploide opened this issue May 28, 2021 · 2 comments · May be fixed by #103

Comments

@exploide
Copy link

When a request from the Postman collections contains a disabled HTTP header

"header": [
    {
        "key": "Content-Type",
        "value": "application/xml",
        "type": "text",
        "disabled": true
    }
]

it ends up being enabled in the generated k6 script:

headers: {
    "Content-Type": "application/xml"
}

This may break the request processing and leads to different results when run from Postman or k6.

I propose don't importing disabled headers or alternatively, have them commented out in the resulting script (if this is easily possible).

@thim81
Copy link
Contributor

thim81 commented Aug 18, 2021

@exploide, I have provided a alternative forked NPM package version that contains this new feature.

Replace in your packages.json:

"dependencies": {
    "postman-to-k6": "^1.5.0"
  }

to

"dependencies": {
    "@apideck/postman-to-k6": "^1.6.0"
  }

This is a forked NPM package, to provide the new functionality to users. The current maintainers are quite overloaded by the acquisition of K6 by Grafana. By forking the repo & package, users can keep using new PR's & (security) fixes. At a later stage the changes can potentially be merged back in the original postman-to-k6 repo.

The changelog contains the differences between the original package & the forked version.

@ppcano
Copy link
Collaborator

ppcano commented Nov 22, 2021

Apologies for the inactivity on this project.

Due to the inability to properly support this project, the k6 team has decided not to continue its development. The primary reason is that k6 scope has grown significantly with the launch of k6 extensions. The team is prioritizing extending k6 capabilities over the converters.

We suggest you post your issue at api-deck/postman-to-k6. The project is active and maintained on this fork.

@ppcano ppcano closed this as completed Nov 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants