New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing Pulsar metrics batch in integration tests #39

Closed

56quarters opened this issue Dec 17, 2020 · 0 comments

Labels

Type: Bug

Contributor

56quarters commented Dec 17, 2020

Per the comment here, an extra batch of metrics has to be sent to force Pulsar to flush the metrics we expect:

https://github.com/grafana/prometheus-pulsar-remote-write/blob/master/integration/consume_integration_test.go#L192

We should investigate what causes this and fix it (this would allow us to test on the exact number of metrics/batches sent).

jtlisi added the Type: Bug label

danmdinu closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment