Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the case_insensitive argument to case_sensitive #117

Closed
kelnage opened this issue Dec 20, 2023 · 0 comments · Fixed by #130
Closed

Change the case_insensitive argument to case_sensitive #117

kelnage opened this issue Dec 20, 2023 · 0 comments · Fixed by #130
Assignees
Labels
backend Related to changes to the query backend velocity Issues that improve our velocity

Comments

@kelnage
Copy link
Collaborator

kelnage commented Dec 20, 2023

When adding the ability to configure how the conversion backend works with queries that do not require case insensitivity (the default for Sigma rules), the variable to control this was named case_insensitive. However, this is a negative statement, which has lead to confusion for end-users and developers, so renaming it to case_sensitive should help alleviate this issue.

One concern about making this change is it would inconvenience any existing users, so we could look into creating a backwards compatibility approach of deprecating (but not disabling) the case_insensitive flag whilst pushing users to move to case_sensitive with a warn or similar (and produce an error if both are set in opposition). Doing so would make this a medium size task.

@kelnage kelnage added the backend Related to changes to the query backend label Dec 20, 2023
@kelnage kelnage added the velocity Issues that improve our velocity label Dec 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Related to changes to the query backend velocity Issues that improve our velocity
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants