Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hot config reload #105

Open
tomershafir opened this issue Aug 1, 2023 · 0 comments
Open

Add hot config reload #105

tomershafir opened this issue Aug 1, 2023 · 0 comments

Comments

@tomershafir
Copy link
Contributor

tomershafir commented Aug 1, 2023

Add configurable hot config file reload mechanism to support kube ConfigMap pyroscope.properties updates that dont trigger restart.

Linux inotify (upon which the jvm watch service virtualizes) has pitfalls, like inability to track NAS which are provided in modern clouds (like Amazon EFS NAS). I guess other OSs have push pitfalls, too. Also, some OSs dont support push, so the jvm polls internally. Thus, I would suggest pull model with 15m or so default interval configurable via --config-check-interval and a /reload real time endpoint.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant