Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce boilerplate code through the use of Lombok #124

Closed
zalintyre opened this issue Oct 15, 2023 · 2 comments
Closed

Reduce boilerplate code through the use of Lombok #124

zalintyre opened this issue Oct 15, 2023 · 2 comments

Comments

@zalintyre
Copy link
Contributor

zalintyre commented Oct 15, 2023

I'd like to propose the use of Project Lombok to reduce boilerplate code like equals, toString, hashcode and many more. What do you think?

@zalintyre
Copy link
Contributor Author

I created a draft PR so you can see what I was thinking of: #127

@korniltsev
Copy link
Collaborator

Hello,

Thank you for your contribution. After reviewing the changes, I'd like to share a few thoughts:

  • The code you referred to as "boilerplate" appears essential in both the before and after cases. I appreciate its purpose and believe it's not superfluous.
  • While Lombok has its merits, I personally feel it somewhat diverges from the core Java principles. For the sake of keeping the project consistent, I'd prefer we stick to standard Java.
  • In terms of dependencies, my aim for this project is to minimize them as much as possible, including potentially removing existing ones like okhttp and the transitive kotlin stdlib.

I hope you understand my perspective. I value your efforts and would welcome further discussions on improving the project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants