Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pprof format natively #128

Open
tomershafir opened this issue Oct 16, 2023 · 1 comment
Open

Support pprof format natively #128

tomershafir opened this issue Oct 16, 2023 · 1 comment

Comments

@tomershafir
Copy link
Contributor

tomershafir commented Oct 16, 2023

The pyroscope ecosystem is around Go pprof. I think it makes sense that the agent would be able to emit pprof natively in order to improve data flows that would operate on the canonical form. It can make them simpler and more efficient. For example:

  • it will make writing tools in different languages easier with the oss pprof support, as I only see async-profiler java jfr2pprof (which you use in JPProf) and your Go server parser for JFR. I have a node app (unfortunately) where I need to simulate some pyroscope api and I would like to receive pprof
  • apply a more efficient format early
  • provide flexibility to tradeoff parse performance overhead across the pipeline depending on the use case, for example offload large scale parse work to the distributed data plane where it may be more negligible.

I think this should be complementary to an agent capability grafana/alloy#395

@cyriltovena
Copy link

cyriltovena commented Oct 23, 2023

Yes please I think the best we could do is actually send using the new API so all in for doing a pprof conversion.

This will make also Grafana Agent integrations much easier for java.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants