Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tags through setting environment of variables #60

Closed
nthnb opened this issue Jul 28, 2022 · 3 comments
Closed

Add tags through setting environment of variables #60

nthnb opened this issue Jul 28, 2022 · 3 comments

Comments

@nthnb
Copy link

nthnb commented Jul 28, 2022

Hi, a feature request that would be really helpful for us would be to be able to add tags to our samples via setting of environment variables for the agent. For instance, if we set:
PYROSCOPE_PROFILER_TAG_XXX=yyy

This could be converted to:
Pyroscope.setStaticLabels(Map.of("xxx", System.getenv("PYROSCOPE_PROFILER_TAG_XXX")));

This would be variable helpful if we wanted to filter by say, deployment version of our apps. Please let me know you need any more information! Thanks

@Rperry2174
Copy link

Rperry2174 commented Jul 28, 2022

Hi @nthnb we just added this recently in #57.

You can find docs for it here

Let us know if we can improve the docs or feature in any way (or if you are requesting something different)!

@nthnb
Copy link
Author

nthnb commented Jul 28, 2022

Perfect! I missed that when looking through the docs, that's my bad. Thanks for the help! I'll close this issue now

@nthnb nthnb closed this as completed Jul 28, 2022
@Rperry2174
Copy link

no worries @nthnb please let us know if you have any other feedback / requests!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants