Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CI #111

Open
7 of 12 tasks
korniltsev opened this issue Jun 21, 2023 · 2 comments
Open
7 of 12 tasks

Improve CI #111

korniltsev opened this issue Jun 21, 2023 · 2 comments

Comments

@korniltsev
Copy link
Collaborator

korniltsev commented Jun 21, 2023 •
edited

currently we suffer from couple of things

  • arm runners
  • macos runners
  • a lot of build logic is located in gh actions yamls

We could improve

  • - use grafana drone ci to leverage its runners
    • drone is not running on main branch, only PR
    • Do not use drone CI
  • - run everything in docker, do not rely on runner python/ruby version
  • when running manylinux.sh - create a docker image from scratch instead of mounting a dir with docker run
  • - use cargo workspaces
  • - create makefiles/scripts to do the build so that build logic is in the makefiles and not in yaml
  • - automatically bump version https://github.com/grafana/pyroscope-rs/actions/runs/5343723738
  • - publish rbspy fork to crates
  • - publish cli to crates
  • - subprojects seem to not share build cache for some reason - if I build ffi/python and ffi/ruby, libraries seem to be built from scratch, not sure why
  • run tests on all architectures (arm64,amd64), platforms (linux, mac)
@kolesnikovae
Copy link
Contributor

kolesnikovae commented Mar 22, 2024 •
edited

Also, we should make sure that versions are not changing on their own:
#134 (comment)

I've updated the build image for now, but this is not a solution

@kolesnikovae
Copy link
Contributor

Another issue is that we're currently using pyroscope.cloud in tests: #154

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@korniltsev @kolesnikovae