Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

version 0.5.7 appears to break for crates in workspaces on linux Ubuntu 20.04 #133

Open
rajsahae opened this issue Aug 26, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@rajsahae
Copy link

rajsahae commented Aug 26, 2023

Describe the bug you encountered:

We updated pyroscope to 0.5.7 (from 0.5.5) which pulls in pprofrs 0.2.7 (from 0.2.5) and noticed our crates stopped reporting frame data. C++ binding crates still reported.

After some investagation, we realized that the basic example compiled inside our crate workspace would fail in the same way, but outside the workspace, it was fine.

We then ran an experiment between pyroscope 0.5.5 and 0.5.7 (also with rust versions 1.65 and 1.71) with and without workspaces. It seems clear that workspaces are the problem, and it used to be fine on 0.5.5.

See the table below of permutations tested

rust version: 1.65, 1.71
workspace: true, false
pyroscope: 0.5.5 (pyroscope_pprofrs 0.2.5, pprof 0.11.7), 0.5.7 (pyroscope_pprofrs 0.2.7, pprof 0.12.1)


scenarios

RV			WS				PS			Result
============================================================================================
1.65			false			        0.5.5			OK
1.65			false			        0.5.7			OK
1.71			false			        0.5.5			OK
1.71			false			        0.5.7			OK

1.65			true				0.5.5			OK
1.65			true				0.5.7			Fail
1.71			true				0.5.5			OK
1.71			true				0.5.7			Fail

What did you expect to happen instead?

We expect that the basic example compiled inside a crate workspace should still show frame data in pyroscope.

How did you install pyroscope-rs?

Added as a crate dependency and the binary is built via cargo build.

pyroscope-rs version and environment

Ubuntu 20.04
rust versions 1.65 and 1.71
gcc/g++ 10.3.0

I have attached a tarball of the experiment files used, in case that helps.

pyrotest.zip

@rajsahae rajsahae added the bug Something isn't working label Aug 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant