Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not working with Ruby 3.2.0 and higher #80

Closed
AnotherRegularDude opened this issue Feb 16, 2023 · 7 comments
Closed

Not working with Ruby 3.2.0 and higher #80

AnotherRegularDude opened this issue Feb 16, 2023 · 7 comments
Labels
bug Something isn't working

Comments

@AnotherRegularDude
Copy link

AnotherRegularDude commented Feb 16, 2023

Describe the bug you encountered:

When starting a server on Ruby 3.2, pyroscope writes an error in the logs that the current version of Ruby is not supported: rails thread '<unnamed>' panicked at 'The target process's Ruby version is not supported yet. In the meantime, you can try using --force-version 3.2.0
In this case, the application works as expected, except that nothing is sent to the pyroscope server.
...

What did you expect to happen instead?

Pyroscope works with Ruby version 3.2.

...

How did you install pyroscope-rs?

Using ruby gem from there https://rubygems.org/gems/pyroscope


Pyroscope gem version: 0.5.1
Ruby version: 3.2.0
OS: Debian
Also, Ruby running with enabled JIT.

@AnotherRegularDude AnotherRegularDude added the bug Something isn't working label Feb 16, 2023
@korniltsev
Copy link
Collaborator

Yeah, I will update rbspy shortly

@korniltsev
Copy link
Collaborator

or not so shortly.. I will need to figure out how to update our rbspy fork.
I will keep you updated.

@AnotherRegularDude
Copy link
Author

AnotherRegularDude commented Feb 21, 2023

Hi
I see that the PR is merged =)
Does it make sense now to build a gem from a main and build binary in our CI?
Or you'll soon push the gem to rubygems.

@korniltsev
Copy link
Collaborator

it is building right now
https://github.com/pyroscope-io/pyroscope-rs/actions/runs/4230535373
waiting for macos runners to pick up the job

@AnotherRegularDude
Copy link
Author

Oh, I see now
Thank you!

@korniltsev
Copy link
Collaborator

fixed in 0.5.2 gem

@AnotherRegularDude
Copy link
Author

Working perfectly

Thank you =)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants