Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump the clap from 3.x to 4.x #92

Closed
hi-rustin opened this issue Mar 19, 2023 · 2 comments
Closed

Bump the clap from 3.x to 4.x #92

hi-rustin opened this issue Mar 19, 2023 · 2 comments

Comments

@hi-rustin
Copy link
Contributor

Clap was released for a while. I think maybe it would be nice to upgrade the clap from 3.x to 4.x for the pyroscope CLI.

If you think it makes sense I can help to add UI tests for CLI and bump the clap version.
@korniltsev
Copy link
Collaborator

Does it require to update rust toolchain? I would like to keep 1.63 for as long as possible because 1.64 bumps glibc dependency, preventing running pyroscope-rs on ridiculously old systems for no good reason for pyroscope. If it does not require to update toolchain - I am open to upgrade

@hi-rustin
Copy link
Contributor Author

hi-rustin commented Mar 19, 2023 •
edited

If it does not require to update toolchain - I am open to upgrade

I think we can at least we can get 4.0 without updating the toolchain.

@hi-rustin hi-rustin mentioned this issue Mar 21, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@korniltsev @hi-rustin