Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing binaries in pyroscope-cli releases. #96

Closed
AlexBoyd opened this issue Mar 22, 2023 · 1 comment
Closed

Missing binaries in pyroscope-cli releases. #96

AlexBoyd opened this issue Mar 22, 2023 · 1 comment
Labels
bug Something isn't working

Comments

@AlexBoyd
Copy link

AlexBoyd commented Mar 22, 2023

Describe the bug you encountered:

The docs suggest that binaries of the pyroscope-cli should be available under releases, but the tagged releases in github only provide the source code at the moment.

Docs: (https://github.com/pyroscope-io/pyroscope-rs/tree/main/pyroscope_cli#installation)
Example release: (https://github.com/pyroscope-io/pyroscope-rs/releases/tag/cli-0.2.1)

Looking at the actions definition, the release process for the cli does build the crate and publish that, but doesn't upload the binary to the releases page as far as I can tell. (https://github.com/pyroscope-io/pyroscope-rs/blob/main/.github/workflows/publish.yml#L26)

...

What did you expect to happen instead?

Binaries available on the releases page, for easy installation into environments without the full rust tool chain setup.
...

@AlexBoyd AlexBoyd added the bug Something isn't working label Mar 22, 2023
@korniltsev
Copy link
Collaborator

I've fixed building and publishing to github release and dockerhub, but not crates yet.
https://github.com/grafana/pyroscope-rs/releases/tag/cli-0.2.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants