Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Document API for Push and Querrier services #2156

Closed
cyriltovena opened this issue Jul 21, 2023 · 5 comments
Closed

[DOC] Document API for Push and Querrier services #2156

cyriltovena opened this issue Jul 21, 2023 · 5 comments
Assignees
Labels
documentation Improvements or additions to documentation type/docs Improvements for doc docs. Used by Docs team for project management

Comments

@cyriltovena
Copy link
Contributor

We currently don't have good documentation for the connect API specially the Push and Querier services.

We should definitively document to make integrations with language and other system easier.

@cyriltovena cyriltovena added the documentation Improvements or additions to documentation label Jul 21, 2023
@simonswine
Copy link
Contributor

If possible I would like to build on top of the OpenAPI spec.

Right now we only export the directly mounted endpoints:

https://elements-demo.stoplight.io/?spec=https://raw.githubusercontent.com/grafana/pyroscope/next/api/openapiv2/gen/phlare.swagger.json#/schemas/v1Series

@cyriltovena
Copy link
Contributor Author

I think it might be due because we don't have http option on the proto like the agent.

We don't use those GRPC gateway endpoint ourselves? I wonder if we should use it ?

@simonswine
Copy link
Contributor

I still think we should distinguish clearer between external API surface (something like /ingest, and the QuerierService) and internal API (anything connect go).

For the internal API surface, no guarantees at all, for the external ones we should focus on stability with all our decision and maybe even mount it under a versioned prefix.

@tomershafir
Copy link

@simonswine hey, following slack, imo you have to maintain a stable external api, REST and/or GRPC (I would consider supporting both). Otherwise, developers will have hard time building tools around pyroscope, thus damaging the potential ecosystem.

As part of that, you should maintain a unified human/machine readable documentation. I think OpenAPI for REST and proto(/flatbuffers, better though probably harder to use) for GRPC are great de facto standards which should be used.

For context, my interest here is https://github.com/metrico/qryn.

@pnf
Copy link

pnf commented Oct 15, 2023

There used to be documentation of a REST api at least as of version 0.37, but the old doc pages now redirect to a grafana advertisement. We figure can infer it from ingest_pprof_test.go, ingest_handler_test, and the sample data, but why are you making us do this?

@cyriltovena cyriltovena self-assigned this Oct 27, 2023
@knylander-grafana knylander-grafana changed the title Document API [DOC] Document API Nov 20, 2023
@knylander-grafana knylander-grafana added the type/docs Improvements for doc docs. Used by Docs team for project management label Nov 20, 2023
@knylander-grafana knylander-grafana changed the title [DOC] Document API [DOC] Document API for Push and Querrier services Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation type/docs Improvements for doc docs. Used by Docs team for project management
Projects
None yet
Development

No branches or pull requests

6 participants