-
Notifications
You must be signed in to change notification settings - Fork 577
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Document API for Push and Querrier services #2156
Comments
If possible I would like to build on top of the OpenAPI spec. Right now we only export the directly mounted endpoints: |
I think it might be due because we don't have http option on the proto like the agent. We don't use those GRPC gateway endpoint ourselves? I wonder if we should use it ? |
I still think we should distinguish clearer between external API surface (something like For the internal API surface, no guarantees at all, for the external ones we should focus on stability with all our decision and maybe even mount it under a versioned prefix. |
@simonswine hey, following slack, imo you have to maintain a stable external api, REST and/or GRPC (I would consider supporting both). Otherwise, developers will have hard time building tools around pyroscope, thus damaging the potential ecosystem. As part of that, you should maintain a unified human/machine readable documentation. I think OpenAPI for REST and proto(/flatbuffers, better though probably harder to use) for GRPC are great de facto standards which should be used. For context, my interest here is https://github.com/metrico/qryn. |
There used to be documentation of a REST api at least as of version 0.37, but the old doc pages now redirect to a grafana advertisement. We figure can infer it from |
We currently don't have good documentation for the connect API specially the Push and Querier services.
We should definitively document to make integrations with language and other system easier.
The text was updated successfully, but these errors were encountered: