Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we recover from panics in all API originating paths #3190

Open
simonswine opened this issue Apr 10, 2024 · 0 comments
Open

Ensure we recover from panics in all API originating paths #3190

simonswine opened this issue Apr 10, 2024 · 0 comments

Comments

@simonswine
Copy link
Contributor

We currently are not recovering panics in all cases, when we spawn up async processing in goroutines. That leaves esp. ingesters vulnerable to data loss after a panic.

I am proposing we check all relevant paths and consider replacing it with: https://github.com/kucherenkovova/safegroup

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant