Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle invalid profiles gracefully #3203

Closed
kolesnikovae opened this issue Apr 12, 2024 · 1 comment · Fixed by #3218
Closed

Handle invalid profiles gracefully #3203

kolesnikovae opened this issue Apr 12, 2024 · 1 comment · Fixed by #3218
Assignees
@kolesnikovae
Labels
backend Mostly go code bug Something isn't working enhancement New feature or request

Comments

@kolesnikovae
Copy link
Collaborator

Ingestion handling of pprof is currently quite unsafe, meaning that a panic is possible on any unexpected profile structure. For example, elements with ID 0 (not allowed in pprof) may cause panic like this:

image

Instead, only affected elements should be discarded from the profile, and the valid part should be preserved.
@kolesnikovae kolesnikovae added bug Something isn't working enhancement New feature or request backend Mostly go code labels Apr 12, 2024
@kolesnikovae kolesnikovae self-assigned this Apr 12, 2024
@simonswine simonswine mentioned this issue Apr 13, 2024
Merged
@kolesnikovae kolesnikovae mentioned this issue Apr 15, 2024
Merged
@kolesnikovae
Copy link
Collaborator Author

kolesnikovae commented Apr 15, 2024 •
edited

Note that this specific case is an exclusion: a location may have mapping ID 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kolesnikovae kolesnikovae

Labels
backend Mostly go code bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sanitize pprof references grafana/pyroscope
1 participant
@kolesnikovae