Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert checks page to utilize URL parameters #762

Closed
ckbedwell opened this issue Apr 24, 2024 · 1 comment · Fixed by #797
Closed

Convert checks page to utilize URL parameters #762

ckbedwell opened this issue Apr 24, 2024 · 1 comment · Fixed by #797
Assignees
Labels
enhancement New feature or request frontend Needs to be implemented in the frontend application good first issue Good for newcomers ux Usability issues

Comments

@ckbedwell
Copy link
Contributor

What would you like to be added:
Currently the checks page utilizes localStorage as a way to replicate state. This is problematic for a number of reasons and should be removed. It should be updated by utilizing URL query parameters instead.

Why is this needed:
The localStorage state can be a huge hinderance and unwanted behaviour in certain user workflows. Changing the state to url query parameters means we can persist check page state when navigating the app via back and forward buttons, and it also enables the ability to deep-link and share the checks list page from other applications as well as in peer-to-peer sharing.

Please ensure the solution is easily extensible as we add more filters in the future.

Additional context
Product board link.

@ckbedwell ckbedwell added enhancement New feature or request good first issue Good for newcomers ux Usability issues frontend Needs to be implemented in the frontend application labels Apr 24, 2024
@rdubrock
Copy link
Contributor

rdubrock commented May 2, 2024

Fixing this would close #607

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request frontend Needs to be implemented in the frontend application good first issue Good for newcomers ux Usability issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants