Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enable gateway while disabling jaeger ui #628

Closed
philipgough opened this issue Sep 22, 2023 · 5 comments · Fixed by #705
Closed

Cannot enable gateway while disabling jaeger ui #628

philipgough opened this issue Sep 22, 2023 · 5 comments · Fixed by #705
Labels
enhancement New feature or request

Comments

@philipgough
Copy link

philipgough commented Sep 22, 2023

The following snippet fails for me

      tenants:
        mode: openshift
        authentication:
          - tenantName: application
            tenantId: application
      template:
        gateway:
          enabled: true
        queryFrontend:
          jaegerQuery:
            enabled: false

Error: The TempoStack "tempostack" is invalid: spec.template.gateway.enabled: Invalid value: true: to use the gateway, please enable jaegerQuery

Probably misunderstanding something but the use case is to continue to leverage authn/authz at the gateway without the need for jaeger on the query path (I want the gateway read/write tracing endpoints to point at the Loki components/services) in such a case.

@frzifus
Copy link
Collaborator

frzifus commented Sep 22, 2023

I think is currently not supported since the read path is always referring to the query service.

Args: append([]string{
fmt.Sprintf("--traces.tenant-header=%s", manifestutils.TenantHeader),
fmt.Sprintf("--web.listen=0.0.0.0:%d", portPublic),
fmt.Sprintf("--web.internal.listen=0.0.0.0:%d", portInternal),
fmt.Sprintf("--traces.write.endpoint=%s:4317", naming.ServiceFqdn(tempo.Namespace, tempo.Name, manifestutils.DistributorComponentName)),
fmt.Sprintf("--traces.read.endpoint=%s://%s:16686", httpScheme(params.Gates.HTTPEncryption),
naming.ServiceFqdn(tempo.Namespace, tempo.Name, manifestutils.QueryFrontendComponentName)),
fmt.Sprintf("--grpc.listen=0.0.0.0:%d", portGRPC),
fmt.Sprintf("--rbac.config=%s", path.Join(tempoGatewayMountDir, "cm", tempoGatewayRbacFileName)),
fmt.Sprintf("--tenants.config=%s", path.Join(tempoGatewayMountDir, "secret", manifestutils.GatewayTenantFileName)),
"--log.level=info",
}, tlsArgs...),

But I assume it could be supported. wdyt @andreasgerstmayr ?

@frzifus frzifus added the enhancement New feature or request label Sep 22, 2023
@andreasgerstmayr
Copy link
Collaborator

This validation was added in #278.
I'm a bit confused, where should traces.read.endpoint point to if tempo-query (Jaeger UI) is disabled?

@pavolloffay
Copy link
Collaborator

@rubenvp8510 is adding support for exposing Tempo native API in the gateway observatorium/api#575

@andreasgerstmayr
Copy link
Collaborator

Ah, yes, so in that case we don't support the Jaeger-API compatible endpoints (traces.read.endpoint) but only the Tempo API endpoints (traces.tempo.endpoint). Makes sense.

@philipgough
Copy link
Author

Yes so basically I was trying to run this with a custom built gateway. Sounds like it is all coming together already :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants