Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output additional information about the disks #45

Closed
Pokom opened this issue Feb 21, 2023 · 3 comments · Fixed by #44
Closed

Output additional information about the disks #45

Pokom opened this issue Feb 21, 2023 · 3 comments · Fixed by #44

Comments

@Pokom
Copy link
Contributor

Pokom commented Feb 21, 2023

It would be helpful to output additional information about the disk that is not available via the kubernetes metadata properties. I am specifically looking to see the disk type(SSD vs regular) and size.

These fields will likely grow over time, so it may be useful to have a similar functionality as extraColumns. The only issue with extra columns is it appears to be coupled to kubernetes metadata.

I have an initial implementation in #44 and would be more then happy to share the results.

@inkel
Copy link
Collaborator

inkel commented Feb 22, 2023

I like this idea very much.

I think I'd leave -add-column for picking stuff from the disks metadata, and instead add new boolean flags (defaulting to true or false depending on how useful they are to have all the time, and always true when -v (verbose) is used) for the these, something like:

  • -show-size
  • -show-type

What do you think?

@Pokom
Copy link
Contributor Author

Pokom commented Feb 22, 2023

I like it in theory, I just get a bit concerned about how it impacts the readability of the code. I'd need to see what that looks like implementation wise.

How would you feel about separating the flags to separate issue so?

@inkel
Copy link
Collaborator

inkel commented Feb 22, 2023

How would you feel about separating the flags to separate issue so?

Oh, definitely. Let's just add these by default all the time, we can work output customization later.

@Pokom Pokom closed this as completed in #44 Feb 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants