Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "select all" into UI #53

Open
fedordikarev opened this issue Jul 29, 2023 · 4 comments
Open

Add "select all" into UI #53

fedordikarev opened this issue Jul 29, 2023 · 4 comments

Comments

@fedordikarev
Copy link
Contributor

fedordikarev commented Jul 29, 2023

a "select all" or something similar to batch delete in unused's interface would be handy

@fedordikarev
Copy link
Contributor Author

Meanwhile I think "select all" could be dangerous as it's easy to miss and delete something extra.
My suggestion:
we add flag or two:

  1. -batch-delete to batch delete disks
  2. either second flag like -i-want-to-delete-that-much-disks=n or add that for -batch-delete.

Idea that user provide -batch-delete flag telling that he is ok to delete all the found and filtered disks.
Program will count number of disks after filter applied, and if and only if that number and number in the second flag are the same, we actually delete disks.
If numbers are different, program will show message like: "You asked to delete disks, but after filter applied I will delete disks, here is the list: ..."

so user will check list one more time and verify that they are ok with number and list of disks to delete.

@inkel
Copy link
Collaborator

inkel commented Sep 12, 2023

As we discussed in our meeting, I think that select all should work similarly as what Google Mail does, that is, selecting all that are displayed in the current page and nothing else. So if you're displaying 10 disks but that are 35 disks in total, select all will only select the 10 that are displayed and leave the remaining 25 out of it.

Another possibility is that when the user presses x to delete the disks it shows first a list of what is going to be deleted and then asks for confirmation.

@npazosmendez what do you think? Would that make it safer in your opinion?

@npazosmendez
Copy link

selecting all that are displayed in the current page and nothing else.

That sounds perfect.

Another possibility is that when the user presses x to delete the disks it shows first a list of what is going to be deleted and then asks for confirmation.

And that would be great too.

I think with those two things it will be safe enough.

@npazosmendez
Copy link

It's a bit of a separate topic, but in regards to safety, maybe a -dry-run flag would be nice. It's not like the users can't currently run it without deleting things, but it's nice to be able to run it knowing that no matter what you accidentally do, you won't delete anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants