Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move goja runtime usage out of remote_object.go #1168

Closed
3 tasks done
Tracked by #1182
ankur22 opened this issue Jan 19, 2024 · 0 comments
Closed
3 tasks done
Tracked by #1182

Move goja runtime usage out of remote_object.go #1168

ankur22 opened this issue Jan 19, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Jan 19, 2024

What

Move the usage of goja runtime out of remote_object.go.

Why

We should avoid working with the goja runtime from within the business logic (i.e. outside the mapping layer), because we could be running such code from off the main goja thread (a new goroutine or promise) and when multiple goroutines try to work with the goja runtime at the same time it can cause (avoidable) panics.

Tasks

@ankur22 ankur22 changed the title Can we move goja runtime usage out of remote_object.go? Move goja runtime usage out of remote_object.go Jan 19, 2024
@ankur22 ankur22 self-assigned this Jan 19, 2024
@ankur22 ankur22 added bug Something isn't working team/k6browser To distinguish the issue on project boards. and removed team/k6browser To distinguish the issue on project boards. labels Jan 19, 2024
@inancgumus inancgumus assigned inancgumus and ankur22 and unassigned ankur22 and inancgumus Jan 24, 2024
@ankur22 ankur22 closed this as completed Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants