Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Precalculate the browser version information to prevent I/O calls #1359

Closed
3 tasks done
Tracked by #428
inancgumus opened this issue May 30, 2024 · 0 comments
Closed
3 tasks done
Tracked by #428

Precalculate the browser version information to prevent I/O calls #1359

inancgumus opened this issue May 30, 2024 · 0 comments
Assignees
@inancgumus
Labels
enhancement New feature or request

Comments

@inancgumus
Copy link
Member

inancgumus commented May 30, 2024 •
edited
Loading

What

Precalculate the browser version.

Why

  • To prevent I/O calls when the version and userAgent methods are called.
  • To keep the API consistent with PW. Otherwise, we'd need to turn the methods into async since they make an I/O call.

How

  • Turn panics into errors first
  • Remove the cdpbrowser.GetVersion call from Browser.Version() and Browser.UserAgent
  • Send the cdpbrowser.GetVersion call in NewBrowser and save the version

Tasks
Beta Give feedback
  1. Turn Browser panics into errors #1360
    refactor stability
    inancgumus
  2. Precalculate browser.version and browser.userAgent to prevent the I/O call #1361
    inancgumus

Issue: #1307
@inancgumus inancgumus mentioned this issue May 30, 2024
Closed
@inancgumus inancgumus added async supports async (promises) bug Something isn't working playwright Issue relating to Playwright compatibility compatibility k6 core compatibility enhancement New feature or request and removed bug Something isn't working async supports async (promises) compatibility k6 core compatibility labels May 30, 2024
@inancgumus inancgumus mentioned this issue May 30, 2024
Closed
@inancgumus inancgumus changed the title Convert back browser.version to sync Precalculate browser.version to prevent the I/O call May 30, 2024
@inancgumus inancgumus removed the playwright Issue relating to Playwright compatibility label May 30, 2024
@inancgumus inancgumus changed the title Precalculate browser.version to prevent the I/O call Precalculate browser.version and browser.userAgent to prevent the I/O call May 30, 2024
This was referenced May 30, 2024
Merged
Merged
@inancgumus inancgumus self-assigned this May 30, 2024
@inancgumus inancgumus changed the title Precalculate browser.version and browser.userAgent to prevent the I/O call Precalculate the browser version information to prevent I/O calls May 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@inancgumus inancgumus

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@inancgumus