Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restrict options with a new env var #640

Closed
inancgumus opened this issue Nov 8, 2022 · 1 comment
Closed

Restrict options with a new env var #640

inancgumus opened this issue Nov 8, 2022 · 1 comment
Labels
compatibility k6 core compatibility enhancement New feature or request next Might be eligible for the next planning (not guaranteed!) team/k6browser To distinguish the issue on project boards.
Milestone
v0.9.0

Comments

@inancgumus
Copy link
Member

inancgumus commented Nov 8, 2022 •
edited

In #627, we implemented forcing some of the browser launch options when running in specific environments. However, it turned out that the variable wasn't an environment variable. Instead, we should define a new env var that can restrict options on the Cloud, such as K6_BROWSER_RESTRICTED.

More discussion is here: https://github.com/grafana/k6-cloud-agent/issues/192
@inancgumus inancgumus added the enhancement New feature or request label Nov 8, 2022
@ankur22 ankur22 changed the title Properly detect running in the Cloud Restrict options with a new env var Nov 28, 2022
@inancgumus inancgumus added the compatibility k6 core compatibility label Feb 2, 2023
@inancgumus inancgumus added this to the v0.9.0 milestone Feb 2, 2023
@inancgumus inancgumus self-assigned this Feb 2, 2023
@inancgumus inancgumus added the next Might be eligible for the next planning (not guaranteed!) label Feb 2, 2023
@inancgumus inancgumus added team/k6browser To distinguish the issue on project boards. cloud labels Feb 23, 2023
@inancgumus inancgumus removed their assignment Mar 2, 2023
@ankur22
Copy link
Collaborator

ankur22 commented Mar 30, 2023

We're closing this as we have agreed that the environment itself will help restrict options for us.

@ankur22 ankur22 closed this as not planned Won't fix, can't repro, duplicate, stale Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
compatibility k6 core compatibility enhancement New feature or request next Might be eligible for the next planning (not guaranteed!) team/k6browser To distinguish the issue on project boards.
Projects
None yet
Milestone
v0.9.0
Development

No branches or pull requests
2 participants
@inancgumus @ankur22