Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure that Web Vitals are aggregated based on frame and sub frame #692

Open
ankur22 opened this issue Jan 5, 2023 · 0 comments
Open

Ensure that Web Vitals are aggregated based on frame and sub frame #692

ankur22 opened this issue Jan 5, 2023 · 0 comments
Labels
enhancement New feature or request research

Comments

@ankur22
Copy link
Collaborator

ankur22 commented Jan 5, 2023

This follows on from the POC #657.

At the moment, metrics are aggregated for all the pages that are navigated to. This is likely to be ok for an initial release, but eventually we may want to also aggregate based on the separate frames and sub frames from each page.

There's also a limitation with the Web Vitals JS library, which is that it doesn't work with sub frames. If we were to inject the JS library into sub frames too, how will we want to display the metrics? Can we simply aggregate the results from the root frame and its sub frames?

@ankur22 ankur22 added the enhancement New feature or request label Jan 5, 2023
@ankur22 ankur22 mentioned this issue Jan 5, 2023
3 tasks
@ankur22 ankur22 added this to the v0.9.0 milestone Mar 16, 2023
@inancgumus inancgumus removed this from the v0.9.0 milestone Mar 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request research
Projects
None yet
Development

No branches or pull requests

2 participants