Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to Go's errors.Join from multierror #738

Closed
2 tasks done
ka3de opened this issue Jan 30, 2023 · 0 comments
Closed
2 tasks done

Switch to Go's errors.Join from multierror #738

ka3de opened this issue Jan 30, 2023 · 0 comments
Assignees
Milestone

Comments

@ka3de
Copy link
Collaborator

ka3de commented Jan 30, 2023

As part of the tasks done prior to the merge with k6 core in #734 we got rid of Hashicorp's multierror dependency in favor of our custom implementation that fulfilled our current use case.

This implementation should be replaced by something simpler, and we should also reevaluate if there is a need for multierror in remote_object implementation, which currently is the only component that uses it, or overall in xk6-browser codebase.

A possible candidate to replace the current implementation would be to use Go's support for wrapping multiple errors introduced in v1.20.

Tasks

  1. maintenance refactor
    inancgumus
  2. inancgumus
@ka3de ka3de added the refactor label Jan 30, 2023
@inancgumus inancgumus self-assigned this Apr 7, 2023
@inancgumus inancgumus added this to the v0.10.0 milestone Apr 7, 2023
@inancgumus inancgumus added the blocked We need further action from something/someone to be able to work on the issue label Aug 10, 2023
@inancgumus inancgumus changed the title Replace custom multierror implementation Switch to Go's errors.Join from multierror to remove dependency Feb 14, 2024
@inancgumus inancgumus changed the title Switch to Go's errors.Join from multierror to remove dependency Switch to Go's errors.Join from multierror Feb 14, 2024
@inancgumus inancgumus added maintenance and removed blocked We need further action from something/someone to be able to work on the issue labels Feb 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants