Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log instead of panicking when closing the browser #815

Open
inancgumus opened this issue Mar 7, 2023 · 1 comment
Open

Log instead of panicking when closing the browser #815

inancgumus opened this issue Mar 7, 2023 · 1 comment
Labels
dx developer experience enhancement New feature or request ux

Comments

@inancgumus
Copy link
Member

inancgumus commented Mar 7, 2023

The closing the browser panics even if the previous code already panicked and closed the browser.

One of the solutions is to log if we can't close the browser—instead of panic.

As shown in the #814 script, you can see that the current approach (panicking while closing the browser) creates problems.

  • The code in the try block panics, and catch will silence it, and the finally closes the browser.
  • Since the code panicked, the browser is killed. Another browser.close will cause another panic.
@inancgumus inancgumus added enhancement New feature or request ux dx developer experience labels Mar 7, 2023
@inancgumus inancgumus added this to the v0.9.0 milestone Mar 7, 2023
@inancgumus inancgumus self-assigned this Mar 7, 2023
@inancgumus inancgumus changed the title Log instead of panic when closing the browser Log instead of panicking when closing the browser Mar 7, 2023
@inancgumus inancgumus removed their assignment Mar 13, 2023
@inancgumus inancgumus removed this from the v0.9.0 milestone Mar 31, 2023
@inancgumus
Copy link
Member Author

We decided to keep this in the backlog until it becomes necessary to tackle.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx developer experience enhancement New feature or request ux
Projects
None yet
Development

No branches or pull requests

1 participant