Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept FieldLogger for test browser logCache #841

Closed
ka3de opened this issue Apr 3, 2023 · 0 comments · Fixed by #842
Closed

Accept FieldLogger for test browser logCache #841

ka3de opened this issue Apr 3, 2023 · 0 comments · Fixed by #842
Assignees
@ka3de
Labels
compatibility k6 core compatibility enhancement New feature or request
Milestone
v0.9.0

Comments

@ka3de
Copy link
Collaborator

ka3de commented Apr 3, 2023

The goal of this issue is to fix the test browser logCache implementation to accept a logurs.FieldLogger (as used in the current k6 implementation as of 9a635a5) meanwhile the bigger refactor defined in #818 is done.

Related: #818
Related: #823
@ka3de ka3de added enhancement New feature or request compatibility k6 core compatibility labels Apr 3, 2023
@ka3de ka3de added this to the v0.9.0 milestone Apr 3, 2023
@ka3de ka3de self-assigned this Apr 3, 2023
@ka3de ka3de mentioned this issue Apr 3, 2023
Merged
@ka3de ka3de closed this as completed in #842 Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ka3de ka3de

Labels
compatibility k6 core compatibility enhancement New feature or request
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Update to k6-core master and fix logCache logger grafana/xk6-browser
1 participant
@ka3de