Skip to content
This repository has been archived by the owner on Jan 17, 2024. It is now read-only.

spanName isn't used #29

Closed
agilob opened this issue Jan 17, 2023 · 1 comment
Closed

spanName isn't used #29

agilob opened this issue Jan 17, 2023 · 1 comment

Comments

@agilob
Copy link

agilob commented Jan 17, 2023

Is this intentional?

func (c *TracingClient) WithTrace(fn HttpFunc, spanName string, url goja.Value, args ...goja.Value) (*HTTPResponse, error) {

I'm having a problem where traces sent by version 72eb374947a2ef5291457d86d00eb689d9a23fa4 latest commit, aren't picked up by our services, instead a gateway service generates own trace_id which is carried over to other backends. I started reviewing code and notice the spanName isn't used, but passed with values like HTTP OPTIONS. Should users be able to configure it in Http constructor?

@Blinkuu
Copy link
Contributor

Blinkuu commented Jan 9, 2024

Archiving this repository, as k6/experimental/tracing module is now available in k6 OSS.

@Blinkuu Blinkuu closed this as completed Jan 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants