This repository has been archived by the owner on Dec 8, 2023. It is now read-only.
Maybe we should allow the user to configure this by supplying a config object as well and not strictly enforce config through env vars? #2
Labels
enhancement
New feature or request
Comments
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Maybe we should allow the user to configure this by supplying a config object as well and not strictly enforce config through env vars?
I'm thinking that if an object is supplied as the argument to the function, we should treat that as a client config object, if not - default to
FromEnv. If we decide to go for this, it could be good if we also cover it with a unit test for each of the paths.Originally posted by @simskij in #1 (comment)
The text was updated successfully, but these errors were encountered: