Skip to content
This repository has been archived by the owner on May 21, 2024. It is now read-only.

Support binary GRPC metadata #43

Closed
olegbespalov opened this issue Aug 25, 2023 · 0 comments · Fixed by #46
Closed

Support binary GRPC metadata #43

olegbespalov opened this issue Aug 25, 2023 · 0 comments · Fixed by #46
Assignees
@olegbespalov

Comments

@olegbespalov
Copy link
Collaborator

olegbespalov commented Aug 25, 2023 •
edited

What?

We have to back-port the grafana/k6#3234 to xk6-grpc.

The important part is that this binary metadata support should be also implemented for the Stream's metadata and for Reflections's metadata (grafana/k6#3241). So it's probably worth abstracting parsing logic and re-using it in all places.

Why?

The xk6-grpc is considered as the future version of the k6's grpc module it should have all functionality that has the legacy k6/net/grpc module.
@olegbespalov olegbespalov added good first issue Good for newcomers help wanted Extra attention is needed and removed good first issue Good for newcomers help wanted Extra attention is needed labels Aug 25, 2023
@olegbespalov olegbespalov changed the title Backport "Support binary passed in GRPC metadata" Support binary GRPC metadata Aug 25, 2023
@olegbespalov olegbespalov self-assigned this Aug 30, 2023
@olegbespalov olegbespalov mentioned this issue Aug 31, 2023
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@olegbespalov olegbespalov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Support binary metadata grafana/xk6-grpc
1 participant
@olegbespalov