Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Discuss whether to not move some fields to be int #4

Closed
mstoykov opened this issue Nov 3, 2021 · 1 comment · Fixed by #5
Closed

Discuss whether to not move some fields to be int #4

mstoykov opened this issue Nov 3, 2021 · 1 comment · Fixed by #5

Comments

@mstoykov
Copy link
Contributor

mstoykov commented Nov 3, 2021

This was previously discussed when field types were added, but we didn't change them as it would break if used on an influxdb with the same fields but different types.

Even then I was of the opinion that this might not be so bad given the benefit of all future deployments having more accurate field types, so I guess now is a good time to probably do that?

We might also want to revisit the tag to fields list and see if we should not add some newer tag

@codebien
Copy link
Collaborator

codebien commented Nov 4, 2021

https://github.com/grafana/k6/blob/83281346ee53e0ad6755b23590040cc872b79470/stats/system_tag.go#L85-L113

We have several default tags, I think all of them should be fields, in this way we should reduce the default overload on maintaining indexes for InfluxDB. In the end, if the user needs more they can be enabled.

This is my proposal for default tags pushed as tags: status, method?, scenario, group, check?, error code?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants