Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

SyncProducer performance #9

Closed
victorlcm opened this issue Aug 19, 2021 · 3 comments
Closed

SyncProducer performance #9

victorlcm opened this issue Aug 19, 2021 · 3 comments

Comments

@victorlcm
Copy link
Contributor

Hi 馃憢

I'm currently using this extension in the company I work and we're having some issues regarding the performance of sending the messages to our Kafka Broker. In order to speed up things, me and @knmsk are currently working on a full rewrite to match the new Output struct in k6 repository and also changing the SyncProducer to AsyncProducer.

The Idea is to improve throughput by using the AsyncProducer, batching messages and running in go routines. Also, we think that we should include an option to wait for acks from Kafka or not. This should be a choice for the users if they're willing to lose some messages to gain performance

Please let us know what you think 馃槃

@mstoykov
Copy link
Collaborator

this output is already matching the new Output

var _ output.Output = new(Collector)
.

Other than that I guess this can be beneficial, I just don't know how much, but if you are willing to do it - go for it :)

@victorlcm
Copy link
Contributor Author

@mstoykov yes, sorry, what I meant was to use the helpers like the periodic flusher 馃槃

@mstoykov
Copy link
Collaborator

I am closing this as #10 changed the extension to use the asyncproducer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants