Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify the slow flush warning #118

Open
codebien opened this issue May 11, 2023 · 0 comments
Open

Clarify the slow flush warning #118

codebien opened this issue May 11, 2023 · 0 comments
Labels
enhancement New feature or request

Comments

@codebien
Copy link
Contributor

We should clarify the warning message when a single flush iteration is slow by adding two values with the time required for aggregating and flushing. In this way, it is easier for users to identify where is the potential issue.

o.logger.WithField("nts", nts).
Warnf("%s but it took %s while flush period is %s. Some samples may be dropped.",
okmsg, d.String(), o.config.PushInterval.String())

@codebien codebien added the enhancement New feature or request label May 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant