Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing output while adding SUDO support #3

Closed
lxkuz opened this issue Mar 30, 2021 · 1 comment
Closed

Missing output while adding SUDO support #3

lxkuz opened this issue Mar 30, 2021 · 1 comment
Assignees
@simskij

Comments

@lxkuz
Copy link
Collaborator

lxkuz commented Mar 30, 2021

#2 PR with the problem

Sudo-based SSH commands are running successfully. The problem here is unstable and in most cases empty output from commands. I know the reason is in the multithreading here but I don't know how to resolve it properly. (#2 (comment))
@lxkuz lxkuz changed the title While adding SUDO support we lost the output We have lost the output while adding SUDO support Mar 30, 2021
@lxkuz lxkuz changed the title We have lost the output while adding SUDO support Missing output while adding SUDO support Mar 30, 2021
@lxkuz lxkuz mentioned this issue Apr 10, 2021
Merged
@simskij
Copy link
Contributor

simskij commented Apr 23, 2021

We've decided to not add sudo support, but rather encourage the use of adding permission to the commands needed for the user used in the sudoers file.

@simskij simskij closed this as completed Apr 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simskij simskij

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lxkuz @simskij