Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assert the read/write expect state of each element of the API #18

Open
Tracked by #16
oleiade opened this issue Nov 2, 2022 · 0 comments
Open
Tracked by #16

Assert the read/write expect state of each element of the API #18

oleiade opened this issue Nov 2, 2022 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@oleiade
Copy link
Member

oleiade commented Nov 2, 2022

It was mentioned during internal discussions that we might want to enforce the read-only state of certain properties exposed by the module. We should careful assert and test this property of the API in a test suite.

It was mentioned that a "trick" exists to enforce that in a Goja context: https://github.com/grafana/xk6-websockets/blob/main/websockets/websockets.go#L133-L157

@oleiade oleiade added the enhancement New feature or request label Nov 2, 2022
@oleiade oleiade self-assigned this Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant