Built In wss sessions is creating too many trends

[mkadirtan]

Hi, the built-in metrics for ws_session_duration_seconds etc. include the websocket url. Which is great, but it also includes the query parameters. I'm testing for a socket.io server and the query parameter include user token. That causes k6 to create as many histograms as there are different users. Is it possible to ignore query parameters for this? Maybe we can add this as an option to environment variable?

[olegbespalov]

Hi @mkadirtan

Thanks for the feedback!

You're right, and we have to introduce some workarounds for that.

Let us come up with a decision on how to handle it better (aligning with the core grafana/k6 which has similar changes) and probably implement it ☺️

[mkadirtan]

Thanks for the reply, maybe we can use this issue to track progress

[konovalovsergey]

Hi @olegbespalov
It's reasonable to follow logic of k6 after v0.41.0 (grafana/k6#2703) - replace "url" tag with "name" tag if it exists.
What you will say to that?

[konovalovsergey]

Сan I help with the implementation of this functionality? If this is the right direction. Task doesn't look very difficult.

[olegbespalov]

Hey @konovalovsergey ! Thanks for offering the help! ☺️

Let me quickly confirm with the team that this is the direction in which we want to evolve, and I (or anybody else from the core team) will get back to you!

[olegbespalov]

Hey @konovalovsergey !

I'm sorry for not getting back to you sooner. After an internal conversation, we concluded that the websockets tags (along with the other protocol tags like gRPC) should work the same way HTTP tags work. If the name tag is defined, url should be overwritten with the name's value.

Сan I help with the implementation of this functionality? If this is the right direction. Task doesn't look very difficult.

So if you still want to contribute by implementing this functionality, feel free to do that 👍

[mkadirtan]

@olegbespalov happy you guys came up with a decision on this one 🥳 . @konovalovsergey I hope you still want to implement this, but if you don't, please let me know, then I can have a look at it. But, of course, prefer you to do it 🙏