Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't call conn.Close on the event loop #46

Open
mstoykov opened this issue Apr 19, 2023 · 0 comments
Open

Don't call conn.Close on the event loop #46

mstoykov opened this issue Apr 19, 2023 · 0 comments

Comments

@mstoykov
Copy link
Collaborator

From #44 (comment)

While I did look into this a while back and was left with the impression it is fine due to the doc

Close closes the underlying network connection without sending or waiting for a close message.

This still calls net.Conn#Close which likely while much faster then most other calls will be a blocking one.

I doubt this is as big of a problem as if we were writing messages, but it still better if we do not.

We also do it in a bunch more places so this is not the only place that needs fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant