Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require setting binaryType #67

Open
mstoykov opened this issue Apr 30, 2024 · 0 comments · May be fixed by #65
Open

Require setting binaryType #67

mstoykov opened this issue Apr 30, 2024 · 0 comments · May be fixed by #65

Comments

@mstoykov
Copy link
Collaborator

While #35 will add Blob support at some point, the current API automatically sets binaryType to arraybuffer and as of #64 warns hat this will not be done in the future.

This issue is to discuss and follow through on the actual breaking parts of this breaking change - making binaryType have a different default than arraybuffer. Which is inline with the specification.

Between #35 and this issue, this is the one that is needed to not have breaking changes in the API and to be able to actually stabalize the API in the core k6.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Error out on not setting binarytype to arraybuffer grafana/xk6-websockets
1 participant
@mstoykov