Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider not using gorilla #9

Open
mstoykov opened this issue Jul 21, 2022 · 2 comments
Open

Consider not using gorilla #9

mstoykov opened this issue Jul 21, 2022 · 2 comments
Labels
enhancement New feature or request

Comments

@mstoykov
Copy link
Collaborator

https://github.com/gorilla/websocket isn't exactly known for it's awesome performance an has for years been undermaintained in my (albeit small) experience with it.

Quick goolge search finds us
https://github.com/nhooyr/websocket - which is minimal and idiomatic (author words), but unfortunately hasn't had update since april 2021 :( and likely isn't as performant as:
https://github.com/gobwas/ws - supposedly really efficient, again no release from 2021 this time from July :(

Just because they haven't been updated in a while might not be that big of a problem if they work correctly - I don't think the websockets specification has changed in years.

The more important question likely is which one gives us better performance and does it make sense to move away from gorilla which has served as well so far.

Also possible think to weight in is #3 which might change depending on the implementation we use 🤷

@codebien
Copy link
Contributor

https://github.com/gobwas/ws#status says it passes the Autobahn
https://github.com/nhooyr/websocket has a big draft PR blocked for one year because it doesn't pass Autobahn

@mstoykov
Copy link
Collaborator Author

https://github.com/lesismal/nbio might also be a possibility.

@olegbespalov olegbespalov added the enhancement New feature or request label Jun 13, 2023
@olegbespalov olegbespalov removed their assignment Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants