Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go Mod not updated for transition #25

Closed
knechtionscoding opened this issue Aug 23, 2021 · 1 comment
Closed

go Mod not updated for transition #25

knechtionscoding opened this issue Aug 23, 2021 · 1 comment

Comments

@knechtionscoding
Copy link

Trying to build a docker image:

# Build the k6 binary with the extension
FROM golang:1.16.4-buster as builder

RUN go install github.com/grafana/xk6/cmd/xk6@latest
RUN xk6 build --output /k6 --with github.com/szkiba/xk6-prometheus@latest

# Use the operator's base image and override the k6 binary
FROM loadimpact/k6:latest as runner
COPY --from=builder /k6 /usr/bin/k6

Results in:

 > [builder 2/3] RUN go install github.com/grafana/xk6/cmd/xk6@latest:                                                                                                                                                                                                                      
#9 1.856 go: downloading github.com/grafana/xk6 v0.4.2                                                                                                                                                                                                                                      
#9 1.979 go install github.com/grafana/xk6/cmd/xk6@latest: github.com/grafana/xk6@none updating to                                                                                                                                                                                          
#9 1.979        github.com/grafana/xk6@v0.4.2: parsing go.mod:                                                                                                                                                                                                                              
#9 1.979        module declares its path as: github.com/k6io/xk6
#9 1.979                but was required as: github.com/grafana/xk6
@mstoykov
Copy link
Contributor

thanks for reporting this, but it already has a fix #24 that just waits for some more approvals and to be merged. Sorry for the inconvenience but it happens to collide with peoples vacations and more importantly as per all instructions everywhere go install github.com/k6io/xk6/cmd/xk6@latest still works so everyone following the instructions will get a version still ;)
While after the rename everything will need to be updated to go install go.k6.io/xk6@latest so this is another reason to make it later so we can possibly coordinate to update extensions READMEs ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants