New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
occurrence IDs should be generated by the API #157
Comments
FYI @shrajfr12 |
Dan assigning to you for now. This will go hand in hand with the Go client lib sample revamp. |
I'll take a look. Do we want the server to reject any occurrences with assigned names (to give the user feedback), or should it just silently assign and use its own names? |
I'm addressing this here: #160 |
#160 did this in the v1alpha1 API layer. This needs to be done in the storage layer, so there is still work here. |
I'll take this for the server implementation that uses v1beta1 API. |
In our reference impl of the v1alpha1 Grafeas API, we currently require the occurrence name to be set in CreateOccurrence:
https://github.com/grafeas/grafeas/blob/master/samples/server/go-server/api/server/v1alpha1/impl.go#L101
Occurrence names are output only and their IDs should be generated by the API:
https://github.com/grafeas/grafeas/blob/master/v1alpha1/proto/grafeas.proto#L774
Note this is unlike notes, which you need to set the ID for when creating.
This should be fixed in the v1alpha1 ref impl, or it can wait until we update the ref impl to v1beta1.
The text was updated successfully, but these errors were encountered: