Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provided Dockerfile does not expose Grafeas server #166

Closed
jonpulsifer opened this issue Jun 25, 2018 · 0 comments
Closed

Provided Dockerfile does not expose Grafeas server #166

jonpulsifer opened this issue Jun 25, 2018 · 0 comments

Comments

@jonpulsifer
Copy link
Contributor

I pointed someone at this repo and they said the provided Dockerfile does not work. Upon review the sample server uses localhost instead of 0.0.0.0 such that I had to provide a config file.

Thoughts on making it "work" out of the box?

~/src/github.com/jonpulsifer/grafeas (expose-me) $ docker run -d --rm -p 8080:8080 grafeas
~/src/github.com/jonpulsifer/grafeas (expose-me) $ curl localhost:8080/v1alpha1/projects
{"projects":[],"nextPageToken":"0"}

proposed changes:

index 8c0deaa..f76dd49 100644
--- a/samples/server/go-server/api/server/config/config.go
+++ b/samples/server/go-server/api/server/config/config.go
@@ -41,7 +41,7 @@ type config struct {
 func defaultConfig() *config {
        return &config{
                API: &api.Config{
-                       Address:  "localhost:8080",
+                       Address:  "0.0.0.0:8080",
                        CertFile: "",
                        KeyFile:  "",
                        CAFile:   "",

If this cromulates I'll open a PR

@jonpulsifer jonpulsifer changed the title Provided Dockerfile does not work Provided Dockerfile does not expose Grafeas server Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant