-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Autotools config files and replace them by Meson #1
Conversation
Some containers (in special CentOS 8), there is a problem with Automake. The NetworkManager fails to compile due to a bug. Since it has some problems, it would be a nice opportunity to migrate to Meson build system. Signed-off-by: Julio Faracco <jfaracco@br.ibm.com>
@grahamwhiteuk, I think it still requires some cleanups (remove M4 directory) and adjustments. But it is a nice opportunity to have it working before other GNOME/NM projects. Feel free to make any changes and suggestions. |
Thanks @jcfaracco, I think it would be good to check what the intended future direction of Gnome/NM projects is. I see little point in straying from the current build system if all the related software is going to continue to use it. I'll send a message out on the NetworkManager mailing list to solicit opinion prior to considering whether we should look to merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation should be kept in line with the PR. Please update the README.md file and include this in the request.
The response I got from the NetworkManager list:
Hence, I think we're green light to migrating from Autotools to Meson so I'll properly review the PR when I next get a chance. |
service_name = custom_target ('nm-anyconnect-service-name', | ||
output: 'nm-anyconnect-service.name', | ||
input: 'nm-anyconnect-service.name.in', | ||
command: ['sed', '-e', 's|[@]LIBEXECDIR[@]|' + libexecdir + '|g', '-e', 's|[@]PLUGINDIR[@]/|' + plugindir + '|g', '@INPUT@'], | ||
capture: true, | ||
install: true, | ||
install_dir: join_paths(prefix, 'lib', 'NetworkManager' , 'VPN/')) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think .in
files are supposed to be processed using the configuration_file
directive, see https://mesonbuild.com/Configuration.html
I wanted to pick up from your great start here @jcfaracco so I've not merged this PR but created a new meson branch where I've continued hacking. I think this is in a pretty good state already but need to do some more testing. I can, at present, build the tree using meson and also build a source distribution and RPM build (through mock). |
Some containers (in special CentOS 8), there is a problem with Automake.
The NetworkManager fails to compile due to a bug. Since it has some
problems, it would be a nice opportunity to migrate to Meson build
system.
Signed-off-by: Julio Faracco jfaracco@br.ibm.com